Flink: Dynamic Sink: Fix partition field check in non-immediate update path#15190
Merged
Merged
Conversation
…e path The check to validate partition fields are contained in the equality fields isn't correct. This affects the non-immediate update path of the Dynamic Sink.
pvary
approved these changes
Feb 2, 2026
Contributor
|
Merged to main. |
mxm
added a commit
to mxm/iceberg
that referenced
this pull request
Feb 2, 2026
mxm
added a commit
to mxm/iceberg
that referenced
this pull request
Feb 2, 2026
talatuyarer
pushed a commit
to talatuyarer/iceberg
that referenced
this pull request
Apr 1, 2026
talatuyarer
pushed a commit
to talatuyarer/iceberg
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check to validate partition fields are contained in the equality fields isn't correct. We shouldn't be using the partition name, but the name of the source field. This affects the non-immediate update path of the Dynamic Sink.