Spark: Add sort_by parameter to rewrite_manifests procedure#15467
Merged
RussellSpitzer merged 3 commits intoMar 9, 2026
Conversation
Contributor
Author
|
@RussellSpitzer @singhpk234 @huaxingao can you please help in review , thanks |
| | `table` | ✔️ | string | Name of the table to update | | ||
| | `use_caching` | ️ | boolean | Use Spark caching during operation (defaults to false). Enabling caching can increase memory footprint on executors. | | ||
| | `spec_id` | ️ | int | Spec id of the manifests to rewrite (defaults to current spec id) | | ||
| | `sort_by` | ️ | array<string> | List of partition field names to cluster manifests by. Choosing frequently queried partition fields can reduce planning time by skipping unnecessary manifests. If not set, manifests will be sorted by all partition fields in spec order. | |
Member
There was a problem hiding this comment.
"partition transform names"?
| action.specId(specId); | ||
| } | ||
|
|
||
| if (sortBy != null) { |
Member
There was a problem hiding this comment.
should we fail on an empty array here?
RussellSpitzer
approved these changes
Mar 5, 2026
RussellSpitzer
left a comment
Member
There was a problem hiding this comment.
This generally looks good to me, I have a few little nits
Contributor
Author
|
thanks for the review @RussellSpitzer , have updated the changes |
Member
|
Thanks @hemanthboyina ! Merged |
RjLi13
pushed a commit
to RjLi13/iceberg
that referenced
this pull request
Mar 12, 2026
talatuyarer
pushed a commit
to talatuyarer/iceberg
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
sort_byparameter to therewrite_manifestsstored procedure, exposing thesortByfunctionalitythat was added to
RewriteManifestsSparkAction. Currently, custom manifest clustering by partition fieldsis only accessible through the Java API. This change allows SQL users to specify which partition fields to cluster
manifests by, which can reduce scan planning time by enabling Spark to skip manifests that don't contain relevant
partition values.
Example:
CALL catalog.system.rewrite_manifests(table => 'db.sample', sort_by => array('category'));