Core: Fix BinPackRewriteFilePlanner producing incorrect output file count with max-files-to-rewrite#15576
Merged
huaxingao merged 1 commit intoMar 17, 2026
Conversation
…ount with max-files-to-rewrite
huaxingao
approved these changes
Mar 11, 2026
Contributor
Author
|
Hi @huaxingao would you be able to merge ? |
Contributor
|
Thanks @hemanthboyina for your PR! |
manuzhang
pushed a commit
to manuzhang/iceberg
that referenced
this pull request
Mar 30, 2026
…ount with max-files-to-rewrite (apache#15576)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When max-files-to-rewrite truncates a file group to a subset of files, inputSplitSize and expectedOutputFiles were still computed from the full group's input size. This caused the sort/zorder rewrite strategy to create too many small output files, as numShufflePartitions was overestimated. This fix recomputes the input size from the actual truncated file list.