AWS: Add scheduled refresh for the S3FileIO held storage credentials#15678
Merged
danielcweeks merged 5 commits intoMar 19, 2026
Conversation
nastra
reviewed
Mar 19, 2026
nastra
reviewed
Mar 19, 2026
nastra
reviewed
Mar 19, 2026
nastra
reviewed
Mar 19, 2026
Contributor
|
I believe we have the exact same issue with |
singhpk234
reviewed
Mar 19, 2026
singhpk234
reviewed
Mar 19, 2026
| } | ||
|
|
||
| @Test | ||
| public void credentialRefreshWithinFiveMinuteWindow() { |
Contributor
There was a problem hiding this comment.
can we add a test for multiple prefixes being sent too ? specially for plumbing it with PrefixedS3Client
Contributor
Author
There was a problem hiding this comment.
We're now delegating to the VendedCredentialProvider which already has tests for that case, so I don't think it's necessary to duplicate here.
nastra
reviewed
Mar 19, 2026
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
nastra
approved these changes
Mar 19, 2026
This was referenced Mar 20, 2026
manuzhang
pushed a commit
to manuzhang/iceberg
that referenced
this pull request
Mar 30, 2026
…pache#15678) * AWS: Add scheduled refresh for the S3FileIO held storage credentials Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The S3FileIO implementation never refreshes the credentials that are held directly from the table load. The s3 clients use a VendedCredentialProvider that internally refreshes the AWS client, but those updates are not reflected back to the FileIO.
If an S3FileIO instance is serialized to remote workers, the credentials may be expired triggering a thundering herd of requests to refresh immediately.
This change addresses this problem by proactively updating the credentials in the FileIO so that only valid credentials are propagated to remote clients.