Core: Support nulls in StructLike collections#2929
Merged
Conversation
Contributor
Author
Contributor
|
Good catch, @aokolnychyi. Any context on where you found this and what kinds of issues it may have caused? |
Contributor
Author
|
I was using this in new writers I have locally to keep track of what partitions we've seen. I had partitions as nulls for unpartitioned writes and it lead to inability to retrieve an existing writer. Don't have a place in the existing codebase that is affected (did not check, to be precise). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
JavaHashesare inconsistent in handling nulls. Specifically, onlyCharSequenceHashcurrently handles nulls correctly and all others fail with a NPE. In addition, ourStructLikecollections don't handle nulls too. It is possible to add a null object but never retrieve it.