Core: Add table property for ORC batch size#3133
Merged
Merged
Conversation
aokolnychyi
commented
Sep 16, 2021
| } | ||
| } | ||
|
|
||
| private int batchSize(FileFormat fileFormat) { |
Contributor
Author
There was a problem hiding this comment.
This PR is a temporary solution until we consume #3132 that will put this logic in one place for Spark 2 and 3.
Contributor
Author
Contributor
Author
rdblue
approved these changes
Sep 17, 2021
rdblue
reviewed
Sep 17, 2021
| private List<Expression> filterExpressions = null; | ||
| private Filter[] pushedFilters = NO_FILTERS; | ||
| private final boolean localityPreferred; | ||
| private final int batchSize; |
Contributor
There was a problem hiding this comment.
How was this set before? Was it just ignored?
Contributor
|
Thanks, @aokolnychyi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new table property to control the ORC batch size. Previously, we used the Parquet batch size for ORC reads.