MR: support imported data reads in input format by using name mapping#3312
Merged
Conversation
rdblue
reviewed
Oct 18, 2021
| if (reuseContainers) { | ||
| avroReadBuilder.reuseContainers(); | ||
| } | ||
| if (nameMapping != null) { |
Contributor
There was a problem hiding this comment.
Nit: empty line bewteen control flow statements
rdblue
approved these changes
Oct 18, 2021
rdblue
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. A minor nit on formatting, but otherwise good.
Contributor
|
Thanks, @edgarRd! |
Contributor
Author
|
Thanks, @rdblue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding name mapping to readers built in
IcebergInputFormat. This will allow Hive to read data imported during Hive -> Iceberg table migration, which otherwise fails with NPE while trying to resolve the Iceberg types in the parquet/orc files.Since the change is pretty straightforward - and we have this same behavior in all other readers - I've not added more unit tests. We also already have extensive name mapping unit tests. However, if folks feel we need a unit test for this I'm happy to add it. I've validated this change by reading via Hive using the
IcebergInputFormaton a migrated table.PTAL @pvary @aokolnychyi