Core: delete previous metadata locations in dropping table with purge enabled#3622
Merged
Conversation
jackye1995
reviewed
Nov 29, 2021
|
|
||
| Tasks.foreach(Iterables.transform(metadata.previousFiles(), TableMetadata.MetadataLogEntry::file)) | ||
| .noRetry().suppressFailureWhenFinished() | ||
| .onFailure((manifest, exc) -> LOG.warn("Delete failed for previous metadata file: {}", manifest, exc)) |
Contributor
There was a problem hiding this comment.
variable name is not manifest, maybe metadataFile?
Contributor
|
Could you add a check in tests to verify the behavior? |
Contributor
Agreed. A test that actually lists the files afterwards would be really helpful. |
Contributor
Author
|
Thank you @jackye1995 @kbendick for the fast review! I'll leave this PR open till tomorrow morning, if there are no further comments I'll merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change deletes the old metadata.json files in
dropTableDatawhich will be invoked by drop table withpurge=true. Today only the latest metadata.json file will be deleted. Please see email thread https://lists.apache.org/thread/p59hn1dqoqs4r3z90tvlxx2wmv01g6fs for details.I don't think we have any existing unit test around this, but I have tested the change locally and also added unit tests for the same method.