AWS: remove S3URI scheme restrictions#3656
Merged
Merged
Conversation
Contributor
Author
|
looks like flaky test, restart CI |
rdblue
reviewed
Dec 3, 2021
| ValidationException.check(authoritySplit.length == 2, "Invalid S3 URI: %s", location); | ||
| ValidationException.check(!authoritySplit[1].trim().isEmpty(), "Invalid S3 key: %s", location); | ||
| ValidationException.check(authoritySplit.length == 2, | ||
| "Cannot determine bucket in S3 URI path: %s", location); |
Contributor
There was a problem hiding this comment.
The bucket isn't in the URI path element, it is in the authority. Maybe just "Cannot determine bucket in S3 URI" instead? Or make it match my suggestion below with Invalid S3 URI, cannot determine bucket: %s.
Contributor
Author
There was a problem hiding this comment.
I see. I always thought authority is a part of path... updated
rdblue
reviewed
Dec 3, 2021
| ValidationException.check(authoritySplit.length == 2, | ||
| "Cannot determine bucket in S3 URI path: %s", location); | ||
| ValidationException.check(!authoritySplit[1].trim().isEmpty(), | ||
| "Cannot determine object key in S3 URI path: %s", location); |
Contributor
There was a problem hiding this comment.
What about Invalid S3 URI, path is empty: %s?
rdblue
approved these changes
Dec 3, 2021
Contributor
|
Looks good overall. I'd probably fix some of the error messages that were updated to be more specific. |
Contributor
Author
|
Given Ryan approves this and all error messages are fixed, I am merging this. @danielcweeks Let me know if you have any additional concern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the mailing list: https://mail-archives.apache.org/mod_mbox/iceberg-dev/202112.mbox/%3CCAMwmD1_P2PCMpzUai5RV%2B4a9Bv62ZFqrrDdxCtLcTSvPnUxk6g%40mail.gmail.com%3E
Based on what Piotr said,
It seems to make more sense to just remove the restriction entirely instead of extending the list of allowed schemes.
@rdblue @danielcweeks @findepi @mayursrivastava