AWS: Add S3 Tagging#4259
Merged
Merged
Conversation
jackye1995
reviewed
Mar 4, 2022
5e20918 to
743ab6f
Compare
jackye1995
reviewed
Mar 8, 2022
jackye1995
reviewed
Mar 8, 2022
jackye1995
reviewed
Mar 8, 2022
53bb7fe to
dd95b29
Compare
Contributor
Author
|
I took the idea of parsing the properties beginning with a prefix from #4011 Refer method name: |
jackye1995
reviewed
Mar 9, 2022
jackye1995
left a comment
Contributor
There was a problem hiding this comment.
logic mostly looks correct to me, added some comments
singhpk234
reviewed
Mar 10, 2022
43240dd to
79fb20b
Compare
singhpk234
approved these changes
Mar 10, 2022
singhpk234
left a comment
Contributor
There was a problem hiding this comment.
LGTM, Thanks @rajarshisarkar !!! for all the work.
jackye1995
reviewed
Mar 11, 2022
jackye1995
reviewed
Mar 11, 2022
jackye1995
reviewed
Mar 11, 2022
jackye1995
reviewed
Mar 11, 2022
jackye1995
reviewed
Mar 11, 2022
jackye1995
reviewed
Mar 11, 2022
jackye1995
reviewed
Mar 11, 2022
jackye1995
reviewed
Mar 11, 2022
amogh-jahagirdar
approved these changes
Mar 14, 2022
amogh-jahagirdar
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds S3 Tags to the objects while writing using
S3FileIO. Users can pass their custom tags as part of the catalog properties.Spark SQL launch command:
Tags added in S3:
cc: @jackye1995 @arminnajafi @singhpk234 @amogh-jahagirdar @xiaoxuandev @yyanyy