Spark [3.2] : Improve stats estimation for spark scan#4446
Merged
rdblue merged 3 commits intoApr 3, 2022
Merged
Conversation
2e0a149 to
c501dc7
Compare
rdblue
reviewed
Mar 31, 2022
rdblue
reviewed
Mar 31, 2022
rdblue
approved these changes
Apr 3, 2022
Contributor
|
Thanks, @singhpk234! |
singhpk234
pushed a commit
to singhpk234/iceberg
that referenced
this pull request
Apr 4, 2022
singhpk234
pushed a commit
to singhpk234/iceberg
that referenced
this pull request
Apr 4, 2022
RussellSpitzer
pushed a commit
that referenced
this pull request
Apr 4, 2022
RussellSpitzer
pushed a commit
that referenced
this pull request
Apr 4, 2022
felixYyu
added a commit
to felixYyu/iceberg
that referenced
this pull request
Apr 10, 2022
felixYyu
added a commit
to felixYyu/iceberg
that referenced
this pull request
Apr 10, 2022
This was referenced Sep 13, 2022
sunchao
pushed a commit
to sunchao/iceberg
that referenced
this pull request
May 9, 2023
Co-authored-by: Prashant Singh <psinghvk@amazon.com> (cherry picked from commit 4ab4b91)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per my understanding, presently we don't take
SplitScanTask(which also implements FileScanTask),into consideration where we would not be reading the complete file rather a subpart of the file.So in this case it's better to find number of records actually scanned by the task, rather than going to datafile this splitscanTask is based on and get's its complete record count.
At present it seems like we are over-estimating the size by taking complete record count of the file associated with the SplitScanTask, where as we are just scanning the subset of data from this file.
cc @rdblue @aokolnychyi @RussellSpitzer @jackye1995 @wypoon