Infra - Add an explicit workflow for API binary compatibility checks#4798
Merged
Conversation
rdblue
reviewed
May 22, 2022
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| jvm: [8, 11] |
Contributor
There was a problem hiding this comment.
Is this necessary? I don't think that binary compatibility changes that much across JVM versions. It should be fine to run with just 11.
rdblue
reviewed
May 22, 2022
| matrix: | ||
| jvm: [8, 11] | ||
| env: | ||
| SPARK_LOCAL_IP: localhost |
Contributor
There was a problem hiding this comment.
This shouldn't run any Spark jobs. Is this needed?
Contributor
Author
There was a problem hiding this comment.
No it's not needed.
rdblue
reviewed
May 22, 2022
| path: ~/.gradle/caches | ||
| key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }} | ||
| restore-keys: ${{ runner.os }}-gradle | ||
| - run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts |
Contributor
There was a problem hiding this comment.
This looks like it was probably pasted from another workflow.
Contributor
Author
There was a problem hiding this comment.
This is in pretty much every workflow that we have that I've checked. But I don't think it's needed. Let's try without and see. We can always add it in.
e863d63 to
d6f9801
Compare
rdblue
approved these changes
May 29, 2022
Contributor
|
Thanks, @kbendick! Do we also need to remove the checks from running in another workflow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API / ABI compatibility checking tool,
revapi, is supposed to run whenever we run./gradlew buildor./gradlew check.However, for some reason - likely due to caching, this is getting skipped as can be verified in this example PR: #4796
That PR shows that the output of
./gradlew -DflinkVersions=1.13,1.14,1.15 -DsparkVersions=2.4,3.0,3.1,3.2 -DhiveVersions=2,3 build -x test -x javadoc -x integrationTest, which is run duringJava CI, should runrevapi. However,revapiis being skipped in that step per the log output.For the moment, I'm adding an explicit
API Binary Compatibilityworkflow to circumvent this issue.cc @rdblue