Spark: Revert "Spark: Add "Iceberg" prefix to SparkTable name string for SparkUI (#5629)#7273
Conversation
…rkUI (apache#5629)" This reverts commit fc501f3.
RussellSpitzer
left a comment
There was a problem hiding this comment.
We should probably add a "SHOW CREATE TABLE" test in here
|
FYI, @wypoon |
I suggest doing that as a separate change. A revert of a commit should just be a revert, not mixed with other changes. |
|
@wypoon I was thinking of adding the tests in a separate commit to preserve the pure revert commit. Then when the change gets merged we make sure we retain both commits instead of squashing |
jackye1995
left a comment
There was a problem hiding this comment.
thanks for the quick fix!
|
Merging, @amogh-jahagirdar could you also help adding a test case against it? |
|
Thanks @amogh-jahagirdar for investigation/ fix ! |
|
Let's prioritize that SHOW CREATE, test. I really don't want to have a behavior we are guaranteeing that is going untested. |
|
+1 for reverting this. |
Fixes #7239
This reverts commit fc501f3.
Based on #7239 Spark
SHOW CREATE TABLEhas a regression in 1.2 because we prefixIcebergto the SparkTable name. Sincename()is a public API, opting to revert the change to maintain the existing behavior. To get the Spark UI we desire, my recommendation is we look at leveraging another API.@aokolnychyi @RussellSpitzer @sumeetgajjar @szehon-ho @jackye1995 @singhpk234