AWS: Make AuthSession cache static#7289
Merged
Merged
Conversation
Signer instances can be fairly short-lived, meaning that the `AuthSession` cache doesn't get a chance to remove an `AuthSession` from the cache and thus call `AuthSession#stopRefreshing()`.
danielcweeks
approved these changes
Apr 6, 2023
danielcweeks
pushed a commit
that referenced
this pull request
Apr 6, 2023
Signer instances can be fairly short-lived, meaning that the `AuthSession` cache doesn't get a chance to remove an `AuthSession` from the cache and thus call `AuthSession#stopRefreshing()`.
ericlgoodman
pushed a commit
to ericlgoodman/iceberg
that referenced
this pull request
Apr 12, 2023
Signer instances can be fairly short-lived, meaning that the `AuthSession` cache doesn't get a chance to remove an `AuthSession` from the cache and thus call `AuthSession#stopRefreshing()`.
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Signer instances can be fairly short-lived, meaning that the `AuthSession` cache doesn't get a chance to remove an `AuthSession` from the cache and thus call `AuthSession#stopRefreshing()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signer instances can be fairly short-lived, meaning that the
AuthSessioncache doesn't get a chance to remove anAuthSessionfrom the cache and thus callAuthSession#stopRefreshing().