Spark: Consolidate duplicated test methods to TestHelpers#8024
Merged
Conversation
hsiang-c
commented
Jul 9, 2023
szehon-ho
reviewed
Jul 11, 2023
| // Metadata Delete | ||
| Table table = Spark3Util.loadIcebergTable(spark, tableName); | ||
| Set<DataFile> dataFilesBefore = TestHelpers.dataFiles(table); | ||
| Set<DataFile> dataFilesBefore = TestHelpers.uniqueDataFiles(table); |
Member
There was a problem hiding this comment.
Does the test pass with using dataFiles? (if we change to List) Looks like we are just comparing size, which should hopefully work?
Just wanted to avoid another test method if possible.
Contributor
Author
There was a problem hiding this comment.
@szehon-ho Got it.
As long as you don't need uniqueness, I can pick List-based approach and test again.
Contributor
Author
There was a problem hiding this comment.
@szehon-ho List also works (tested locally).
Member
|
Merged, thanks @hsiang-c ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
TestHelpers.