AWS: Update S3 signer spec to allow an optional string body in S3SignRequest.#8361
Merged
Conversation
56415ce to
e03cc7f
Compare
nastra
approved these changes
Aug 21, 2023
nastra
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @amogh-jahagirdar
dramaticlly
approved these changes
Aug 21, 2023
e03cc7f to
02f2dc5
Compare
…Request. Update S3 signer parser implementation to enable serialization/deserialization of the body. Note: This will only be populated for requests which do not transmit relevant data to sign as part of the URI itself (e.g. DeleteObjectsRequest)
02f2dc5 to
a563f9f
Compare
danielcweeks
approved these changes
Aug 21, 2023
danielcweeks
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @amogh-jahagirdar !
Contributor
Author
|
Thanks for review @danielcweeks @nastra ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does the following:
1.) Updates the S3 Signer Spec to allow an optional string body in
S3SignRequest2.) Updates
S3SignRequestParserto support serialization and deserialization of the body.Note: The body field will only be populated for requests which do not have the relevant information for signing in the URI itself (e..g DeleteObjectsRequest)
cc: @danielcweeks @nastra @jackye1995