Core: Ignore split offsets array when split offset is past file length#8925
Merged
amogh-jahagirdar merged 1 commit intoOct 28, 2023
Merged
Conversation
rdblue
approved these changes
Oct 26, 2023
Contributor
|
@amogh-jahagirdar, maybe this time we should create a test to validate |
danielcweeks
approved these changes
Oct 27, 2023
114387d to
0ff2819
Compare
Contributor
Author
Done, added a new test which will exercise both |
nastra
reviewed
Oct 27, 2023
nastra
reviewed
Oct 27, 2023
nastra
reviewed
Oct 27, 2023
0ff2819 to
34eee1b
Compare
34eee1b to
7246d78
Compare
amogh-jahagirdar
added a commit
to amogh-jahagirdar/iceberg
that referenced
this pull request
Oct 28, 2023
rdblue
pushed a commit
that referenced
this pull request
Oct 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from a miss in the fix done in #8860. There's an additional splitOffsetArray method which gets used here
iceberg/core/src/main/java/org/apache/iceberg/BaseContentScanTask.java
Line 134 in aa891ac
Alternatively, we can undo the optimization done here: #8336 (comment) and then the original fix in #8860 would be sufficient, and be simpler. Since the optimization seemed impactful and there was community interest in it, this fix retains it and currently just fixes both cases explicitly.