Core: Add EnvironmentContext to commit summary#9273
Merged
amogh-jahagirdar merged 1 commit intoApr 9, 2024
Conversation
10924c3 to
297d0ff
Compare
Member
Author
|
@amogh-jahagirdar @nastra could you please take a look? |
nastra
reviewed
Dec 12, 2023
Member
Author
|
The failed check is due to a flaky test. I created #9294 to fix it. |
ajantha-bhat
approved these changes
Jan 16, 2024
9144372 to
62ec68a
Compare
nastra
reviewed
Feb 20, 2024
62ec68a to
b0363ef
Compare
nastra
reviewed
Feb 21, 2024
nastra
approved these changes
Feb 21, 2024
nastra
left a comment
Contributor
There was a problem hiding this comment.
LGTM once the test is slightly updated. I think it makes sense to have engine-specific info in the snapshot summary. That way we know from which engine a snapshot has been created from. I'm curious what others think here
/cc @amogh-jahagirdar @aokolnychyi @RussellSpitzer @jackye1995
b0363ef to
8284c12
Compare
nastra
reviewed
Feb 22, 2024
8284c12 to
a57a15f
Compare
a57a15f to
98f9f60
Compare
Member
Author
|
@nastra how can we move this forward? |
98f9f60 to
a8ce2b0
Compare
Contributor
|
@amogh-jahagirdar or @RussellSpitzer can you guys also take a look at this please? |
a8ce2b0 to
efea382
Compare
amogh-jahagirdar
approved these changes
Apr 9, 2024
Contributor
|
Sorry for the delay on reviewing this @manuzhang thanks for adding this, I think the environment details in the summary will be quite helpful. I'll go ahead and merge. Thanks @nastra @ajantha-bhat for reviewing! |
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it's not easy to find the Spark application that has run rewrite files actions. This patch adds application id to commit summary via
EnviromentContext