Skip to content

chore: upgrade nanoarrow dependency#146

Merged
Fokko merged 5 commits into
apache:mainfrom
gty404:upgrade-nanoarrow
Jul 16, 2025
Merged

chore: upgrade nanoarrow dependency#146
Fokko merged 5 commits into
apache:mainfrom
gty404:upgrade-nanoarrow

Conversation

@gty404

@gty404 gty404 commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@gty404 gty404 changed the title chore: upgrade nanoarrow dependency chore: update nanoarrow download URL Jul 16, 2025
@zhjwpku

zhjwpku commented Jul 16, 2025

Copy link
Copy Markdown
Collaborator

I got the following error with the old url, the new url WFM.

CMake Error at nanoarrow-subbuild/nanoarrow-populate-prefix/src/nanoarrow-populate-stamp/download-nanoarrow-populate.cmake:163 (message):
  Each download failed!

    error: downloading 'https://dlcdn.apache.org/arrow/apache-arrow-nanoarrow-0.6.0/apache-arrow-nanoarrow-0.6.0.tar.gz' failed
          status_code: 22
          status_string: "HTTP response code said error"
          log:
          --- LOG BEGIN ---
          Host dlcdn.apache.org:443 was resolved.

1 similar comment
@zhjwpku

zhjwpku commented Jul 16, 2025

Copy link
Copy Markdown
Collaborator

I got the following error with the old url, the new url WFM.

CMake Error at nanoarrow-subbuild/nanoarrow-populate-prefix/src/nanoarrow-populate-stamp/download-nanoarrow-populate.cmake:163 (message):
  Each download failed!

    error: downloading 'https://dlcdn.apache.org/arrow/apache-arrow-nanoarrow-0.6.0/apache-arrow-nanoarrow-0.6.0.tar.gz' failed
          status_code: 22
          status_string: "HTTP response code said error"
          log:
          --- LOG BEGIN ---
          Host dlcdn.apache.org:443 was resolved.

@lidavidm lidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to update to 0.7.0 and stick with dlcdn? archive.apache may be flaky (as we've seen with other dependencies)

@gty404

gty404 commented Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

It might be better to update to 0.7.0 and stick with dlcdn? archive.apache may be flaky (as we've seen with other dependencies)

After upgrading to 0.7.0, there are other compilation issues, and I am resolving them.

@gty404 gty404 changed the title chore: update nanoarrow download URL chore: upgrade nanoarrow dependency Jul 16, 2025
@wgtmac

wgtmac commented Jul 16, 2025

Copy link
Copy Markdown
Member

It might be better to update to 0.7.0 and stick with dlcdn? archive.apache may be flaky (as we've seen with other dependencies)

Perhaps we need to add archive.apache as a fallback url. Otherwise it may break whenever nanoarrow has a new release.

@Fokko Fokko merged commit 7c1ea8a into apache:main Jul 16, 2025
7 checks passed
@Fokko

Fokko commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

Thanks @gty404 for bumping nanoarrow, and thanks @zhjwpku, @wgtmac and @lidavidm for the review 💪

lishuxu pushed a commit to lishuxu/iceberg-cpp that referenced this pull request Jul 17, 2025
@gty404 gty404 deleted the upgrade-nanoarrow branch July 17, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants