fix: use std::move when passing by value in the config#555
Conversation
| ninja==1.13.0 | ||
| mkdocs==1.6.1 | ||
| mkdocs-material==9.6.22 | ||
| pre-commit==4.5.1 |
|
No. But this requires only a single line change. it's currently missing this dependency, so I combined two changes together.
---- Replied Message ----
| From | ***@***.***> |
| Date | 02/06/2026 11:27 |
| To | apache/iceberg-cpp ***@***.***> |
| Cc | 姚军 ***@***.***>,
Author ***@***.***> |
| Subject | Re: [apache/iceberg-cpp] fix: use std::move when pass by value (PR #555) |
@mapleFU commented on this pull request.
In requirements.txt:
@@ -2,3 +2,4 @@ meson==1.3.0
ninja==1.13.0
mkdocs==1.6.1
mkdocs-material==9.6.22
+pre-commit==4.5.1
Is this related?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
| template <typename R, typename... Args> | ||
| struct Trait<R (*)(Args...)> { | ||
| using ReturnType = R::value_type; | ||
| using ReturnType = typename R::value_type; |
There was a problem hiding this comment.
Is this a warning from clang-tidy? I guess that typename may be duplicate here.
There was a problem hiding this comment.
Yes, clang-tidy suggest that. I think it is more straightforward if added.
There was a problem hiding this comment.
According to cppreference(https://en.cppreference.com/w/cpp/language/dependent_name.html), a dependent qualified name is assumed to name a type and no typename is required when a qualified name that appears in type-id, where the smallest enclosing type-id is the type-id in an alias declaration since C++20. Can you show the rule name when you meet clang-tidy warning?
|
I approve the part of |
Thanks for your time—I've updated the PR. |
|
Thanks @SYaoJun for improving this! Perhaps you can create another PR to improve the pre-commit requirement config. |
Hi iceberg-cpp team, I found a clang-tidy warning on my environment.