THRIFT-5587 Introduce uuid as additional builtin type (partially implemented) - #2623
Closed
Jens-G wants to merge 6 commits into
Closed
THRIFT-5587 Introduce uuid as additional builtin type (partially implemented)#2623Jens-G wants to merge 6 commits into
Jens-G wants to merge 6 commits into
Conversation
Jens-G
force-pushed
the
THRIFT-5587
branch
3 times, most recently
from
June 16, 2022 23:54
b6ad22d to
e0b74d1
Compare
Jens-G
force-pushed
the
THRIFT-5587
branch
3 times, most recently
from
June 22, 2022 19:48
2d04adc to
0b67b89
Compare
jimexist
approved these changes
Jun 22, 2022
Member
|
maybe:
|
Jens-G
force-pushed
the
THRIFT-5587
branch
5 times, most recently
from
July 1, 2022 19:13
855ab35 to
69131a2
Compare
Member
Author
|
@jimexist Could you have a look at that and the gradle issue as well?
|
Member
i'm not sure i can find that error - can you point me the link? i want to know which branch and build |
Member
|
also i think "Build / lib-java-kotlin (pull_request)" shall be able to catch all Java related errors and it is green in this pull request |
Member
Author
Jens-G
force-pushed
the
THRIFT-5587
branch
2 times, most recently
from
September 1, 2022 20:12
7d52bb9 to
ddeec4b
Compare
…ule references Client: Delphi Patch: Jens Geyer
…oved self-tests) Client: compiler general, netstd, Delphi Patch: Jens Geyer
Client: xml Patch: Jens Geyer
Client: hx Patch: Jens Geyer Relies on flashultra/uuid#4 being fixed, thus may require using the most recent uuid package from Github instead of the Haxelib package.
Client: java, kt Patch: Jiayu Liu This closes apache#2621
…erging the partially completed uuid implementation to master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains:
Attempt to get the uuid branch cleaned up and mergeable. The ThriftTest.thrift IDL file has been duplicated to have a full version (The ThriftTest.thrift) and a 0.16.x version without uuids (ThriftTest_0_16.thrift) for those language bindings where uuid is not yet available/implemented. When some language implements it, the test file should again be ThriftTest.thrift so that at some point in the future the 0.16.x IDL file can be safely removed.