Clean up hacks used to be making Tahoe lighter#36
Conversation
| chrome: | ||
| image: hello-world | ||
| command: /hello | ||
| elasticsearch: |
There was a problem hiding this comment.
how does removing this enable search on devstack?
There was a problem hiding this comment.
Good question: elasticsearch: image: hello-world was effectively turning off elasticsearch by making it doing nothing.
This is an old hack that is confusing, I've now cleaned it up.
thraxil
left a comment
There was a problem hiding this comment.
We should probably have some better documentation somewhere explaining why we have a compose file full of hello world images.
Now all the services run again. To enable elastic search on devstack.
9aa9089 to
3a89924
Compare
Thanks @thraxil, you're right. The documentation existed as an inline comment. That was difficult to find. I think we don't need this hack anymore so I've restructured this PR to clean up the hack. Please take a look. I also need to check with Matej, Maxi and John to make sure they're aware of the change. |
|
@melvinsoft @johnbaldwin @grozdanowski Are you all using the cloud devstack (aka Sultan) these days? If you're not, then what do you think of reopening the services above? The reason we chose to stop them was to avoid having nasty devstack errors on Mac. The attempts weren't successful so we opted out for Sultan so Mac users can use devstack. |
|
@OmarIthawi I use exclusively the local devstack. To be completely honest, have never tried Sultan nor I know even how to :D |
|
Thanks @grozdanowski. Then heads up! If this ruins your experience, we can revert it quickly. Do you still run of the ancient |
Now all the services run again.
To enable elastic search on devstack to test issues related to
ENABLE_COURSE_DISCOVERY.I've deprecated
tahoe.upin favor ofdev.upsince we're not going to merge enterprise anytime soon with this branch.TODO