This repository was archived by the owner on Jul 27, 2023. It is now read-only.
Remove Range type parameter from AST nodes - #15
Merged
Conversation
Member
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
charliermarsh
approved these changes
Jun 23, 2023
zanieb
pushed a commit
that referenced
this pull request
Jul 10, 2023
zanieb
added a commit
that referenced
this pull request
Jul 17, 2023
zanieb
pushed a commit
that referenced
this pull request
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the range type parameter from all AST nodes because ruff doesn't use it and removes the
all-node-rangesfeatures.Removing the generic type argument should help with compile time of downstream creates because Rust already generates all code for the AST nodes when compiling the ast (no monomorphization in downstream crates)