Ignore upper-bounds on Requires-Python - #4086
Merged
Merged
Conversation
charliermarsh
marked this pull request as ready for review
June 6, 2024 03:50
charliermarsh
force-pushed
the
charlie/requires-python-cap
branch
from
June 6, 2024 03:51
b24decc to
3d46776
Compare
charliermarsh
force-pushed
the
charlie/requires-python-cap
branch
from
June 6, 2024 03:54
3d46776 to
7ddb7dd
Compare
konstin
approved these changes
Jun 6, 2024
zanieb
approved these changes
Jun 6, 2024
SigureMo
added a commit
to yutto-dev/bilili
that referenced
this pull request
Jun 6, 2024
13 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies our
Requires-Pythonhandling to treatRequires-Pythonas a lower bound. There's extensive discussion around this in #4022 and the references linked therein. I think it's an experiment worth trying. Even in my own small projects, I'm running into issues whereby I'm being "forced" to add a<4upper bound to myRequires-Pythondue to these caps.Separately, we should explore adding a mechanism that's distinct from
Requires-Pythonto enable users to declare a supported range for locking.Closes #4022.