Add scatter_contour error bars - #223
Open
arjunsavel wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #222. I've added functionality for
scatter_contourto handle error bars. This essentially amounts to changing theax.scattercall toax.errorbarand ensuring that user inputs (includingNoneforxerrand/oryerr) are properly coerced and passed to the function call. I've tried to do this with minimal disruption to the organization ofscatter_contourwhile replicating the direct function ofax.errorbar, but this definitely isn't the most parsimonious way to go about it.Screen shots for each type of error bar input (as applied to SDSS Stripe 82 standard stars) are below. The only extra
plot_argthat I've added for these figures isecolor='gray'. Happy to add tests or further documentation!