Ensure no unexpected failures in treating deprecations as exceptions.#12389
Merged
Conversation
The current del module.__warningregistry__ fails with a TypeError rather than AttributeError for h5py. It seems reasonable to just skip trying to delete it on any exception. Tests pass after this change.
Contributor
Author
|
Failures unrelated - will be fixed by #12390 |
Member
|
Thanks for the fix! As an aside we really should consider deprecating our custom machinery for treating deprecation warnings as exceptions at some point since it is possible to do the same with pytest options... |
astrofrog
approved these changes
Nov 4, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Nov 4, 2021
…deprecations as exceptions.
astrofrog
added a commit
that referenced
this pull request
Nov 4, 2021
…389-on-v5.0.x Backport PR #12389 on branch v5.0.x (Ensure no unexpected failures in treating deprecations as exceptions.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
del module.__warningregistry__fails with a TypeError rather than AttributeError for h5py.It seems reasonable to just skip trying to delete it on any exception. Tests run after this change. I don't really know how to add a test for this, though, short of testing with more Debian packages in our test grid.
Fixes #12388
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.