Skip to content

Unskip missing link#12634

Closed
nstarman wants to merge 1 commit into
astropy:mainfrom
nstarman:fix-rtd-wraps-link-error
Closed

Unskip missing link#12634
nstarman wants to merge 1 commit into
astropy:mainfrom
nstarman:fix-rtd-wraps-link-error

Conversation

@nstarman

@nstarman nstarman commented Dec 25, 2021

Copy link
Copy Markdown
Member

Signed-off-by: Nathaniel Starkman (@nstarman) nstarkman@protonmail.com

Fixes the broken CI.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman added this to the v5.1 milestone Dec 25, 2021
@github-actions github-actions Bot added the utils label Dec 25, 2021
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@nstarman nstarman added the Bug label Dec 25, 2021
@nstarman nstarman marked this pull request as ready for review December 25, 2021 16:34
@nstarman nstarman requested a review from pllim December 25, 2021 16:35
@nstarman nstarman added the 🔥 Critical label Dec 25, 2021
@pllim

pllim commented Dec 27, 2021

Copy link
Copy Markdown
Member

I don't understand. The CI in main is not broken. Can you please clarify?

Also, good catch on the wraps doc. I have no idea why it is in the module at all. Maybe we can remove it from the docs as part of #12633 since I am getting rid of it over there as well but I think I missed the docs.

@pllim

pllim commented Dec 27, 2021

Copy link
Copy Markdown
Member

This is now part of #12633. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants