Skip to content

Parametrize remote fixtures#2255

Closed
volodymyrss wants to merge 1 commit into
astropy:mainfrom
oda-hub:parametrize-remote-fixtures
Closed

Parametrize remote fixtures#2255
volodymyrss wants to merge 1 commit into
astropy:mainfrom
oda-hub:parametrize-remote-fixtures

Conversation

@volodymyrss

Copy link
Copy Markdown
Contributor

No description provided.

@pep8speaks

pep8speaks commented Dec 23, 2021

Copy link
Copy Markdown

Hello @volodymyrss! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 140:9: E265 block comment should start with '# '

Comment last updated at 2022-03-26 08:59:26 UTC

volodymyrss added a commit to oda-hub/astroquery that referenced this pull request Dec 23, 2021
@bsipocz bsipocz added this to the v0.4.7 milestone Mar 19, 2022
bsipocz pushed a commit to bsipocz/astroquery that referenced this pull request Mar 25, 2022
@bsipocz

bsipocz commented Mar 25, 2022

Copy link
Copy Markdown
Member

@volodymyrss - Is this still relevant? If yes, could you remove the commits that are already in main from #2250, and if not then close it? Thanks!

@volodymyrss volodymyrss force-pushed the parametrize-remote-fixtures branch from 80b2ec1 to e127104 Compare March 26, 2022 08:59
@volodymyrss

Copy link
Copy Markdown
Contributor Author

@volodymyrss - Is this still relevant? If yes, could you remove the commits that are already in main from #2250, and if not then close it? Thanks!

It's still relevant, it's meant to relocate the fixtures for this test parametrization (creating remote data automatically) to common location, not specific to heasarc.
I had no time to finish it yet, sorry. It might take some month before I get to it again. Is it ok to keep it as draft for a while? I could also close and recreate it later.
I made it all in one commit for now.

@bsipocz bsipocz removed this from the v0.4.7 milestone Mar 26, 2022
@bsipocz

bsipocz commented Mar 26, 2022

Copy link
Copy Markdown
Member

Is it ok to keep it as draft for a while?

That sounds all good, as you may have seen we don't put a time limit on PRs in this repo. However, I removed the milestone so it won't pop up at release time.

@bsipocz

bsipocz commented Feb 4, 2025

Copy link
Copy Markdown
Member

The heasarc module has been completely rewritten, so the tests are not that much overlapping any more, thus I'm closing this now. Thank you for working on this!

@bsipocz bsipocz closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants