Skip to content

Fix cache dir creation race confition #2274

Merged
bsipocz merged 1 commit into
astropy:mainfrom
mfisherlevine:patch-1
Feb 1, 2022
Merged

Fix cache dir creation race confition #2274
bsipocz merged 1 commit into
astropy:mainfrom
mfisherlevine:patch-1

Conversation

@mfisherlevine

Copy link
Copy Markdown
Contributor

Fix race condition

Fix race condition
@codecov

codecov Bot commented Feb 1, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2274 (215f99c) into main (cda88ef) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2274      +/-   ##
==========================================
- Coverage   62.72%   62.72%   -0.01%     
==========================================
  Files         131      131              
  Lines       16855    16854       -1     
==========================================
- Hits        10573    10572       -1     
  Misses       6282     6282              
Impacted Files Coverage Δ
astroquery/query.py 58.69% <100.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda88ef...215f99c. Read the comment docs.

@bsipocz bsipocz added this to the v0.4.6 milestone Feb 1, 2022
@bsipocz bsipocz added the testing label Feb 1, 2022
@bsipocz

bsipocz commented Feb 1, 2022

Copy link
Copy Markdown
Member

I'm not yet sure whether we need a changelog for this, so leaving it as is and I'll come back to it at release time when finalizing the release changelog.

@bsipocz bsipocz merged commit 27515e4 into astropy:main Feb 1, 2022
@bsipocz

bsipocz commented Feb 1, 2022

Copy link
Copy Markdown
Member

Thanks @mfisherlevine!

@bsipocz bsipocz linked an issue Feb 1, 2022 that may be closed by this pull request
@bsipocz bsipocz changed the title Issue #2273 Fix cache dir creation race confition Feb 1, 2022
@mfisherlevine

Copy link
Copy Markdown
Contributor Author

You're very welcome, thank you for making the process so easy, and sorry for not managing to follow the procedures a little better, was in a huge hurry last night and was trying to get that in before running out the door!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Race condition in tests with query with multiple test runners

2 participants