Skip to content

Fix fixture usage for remote test#2310

Merged
bsipocz merged 1 commit into
astropy:mainfrom
bsipocz:alma_fix_fixture_for_remote_test
Mar 1, 2022
Merged

Fix fixture usage for remote test#2310
bsipocz merged 1 commit into
astropy:mainfrom
bsipocz:alma_fix_fixture_for_remote_test

Conversation

@bsipocz

@bsipocz bsipocz commented Feb 25, 2022

Copy link
Copy Markdown
Member

This was a minor bug added in #2246, the lesson to learn is to run the remote tests before merging a PR.

_________________________________________________________________________________________________________________ test_download_html_file __________________________________________________________________________________________________________________

    @pytest.mark.remote_data
    def test_download_html_file():
>       result = alma.download_files(['https://almascience.nao.ac.jp/dataPortal/member.uid___A001_X1284_X1353.qa2_report.html'])
E       AttributeError: 'function' object has no attribute 'download_files'

astroquery/alma/tests/test_alma_remote.py:656: AttributeError

@bsipocz bsipocz added this to the v0.4.6 milestone Feb 25, 2022
@bsipocz

bsipocz commented Feb 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

There are a few remaining remote data test failures, some of which looks real, if you, @keflavich or @andamian could look at them separately it would be superb:

FAILED astroquery/alma/tests/test_alma_remote.py::TestAlma::test_freq - pyvo.dal.exceptions.DALFormatError: ProtocolError: ('Connection broken:...
FAILED astroquery/alma/tests/test_alma_remote.py::TestAlma::test_data_info - FileNotFoundError: [Errno 2] No such file or directory: '/var/fold...
FAILED astroquery/alma/tests/test_alma_remote.py::TestAlma::test_download_data - AssertionError: assert 0 == 2
FAILED astroquery/alma/tests/test_alma_remote.py::TestAlma::test_download_and_extract - assert 0 > 1

@codecov

codecov Bot commented Feb 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2310 (248ff4d) into main (6834ef9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2310   +/-   ##
=======================================
  Coverage   63.08%   63.08%           
=======================================
  Files         131      131           
  Lines       17005    17005           
=======================================
  Hits        10728    10728           
  Misses       6277     6277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6834ef9...248ff4d. Read the comment docs.

@bsipocz bsipocz merged commit d2d3b21 into astropy:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

alma merge-when-ci-passes no-changelog-entry-needed testing

Projects

None yet

Milestone

v0.4.6

Development

Successfully merging this pull request may close these issues.

1 participant

@bsipocz