Skip to content

Decode plus signs in filenames when downloading#2319

Merged
bsipocz merged 3 commits into
astropy:mainfrom
jd-au:CASDA-Download-file-names-with-plus
Mar 3, 2022
Merged

Decode plus signs in filenames when downloading#2319
bsipocz merged 3 commits into
astropy:mainfrom
jd-au:CASDA-Download-file-names-with-plus

Conversation

@jd-au

@jd-au jd-au commented Mar 3, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@pep8speaks

pep8speaks commented Mar 3, 2022

Copy link
Copy Markdown

Hello @jd-au! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-03-03 04:45:57 UTC

@codecov

codecov Bot commented Mar 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2319 (09f07d2) into main (5258370) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2319   +/-   ##
=======================================
  Coverage   63.09%   63.09%           
=======================================
  Files         131      131           
  Lines       17037    17037           
=======================================
  Hits        10750    10750           
  Misses       6287     6287           
Impacted Files Coverage Δ
astroquery/casda/core.py 90.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5258370...09f07d2. Read the comment docs.

@jd-au jd-au added the casda label Mar 3, 2022
@bsipocz bsipocz added this to the v0.4.6 milestone Mar 3, 2022
@bsipocz bsipocz added the bug label Mar 3, 2022
@bsipocz bsipocz merged commit 428bbb4 into astropy:main Mar 3, 2022
@bsipocz

bsipocz commented Mar 3, 2022

Copy link
Copy Markdown
Member

Thank you @jd-au!

@jd-au jd-au deleted the CASDA-Download-file-names-with-plus branch April 22, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants