Skip to content

Verify SSL certificates for FIRST, MAGPIS#2350

Merged
bsipocz merged 1 commit into
astropy:mainfrom
keflavich:verify_https_FIRSTandMAGPIS
Mar 29, 2022
Merged

Verify SSL certificates for FIRST, MAGPIS#2350
bsipocz merged 1 commit into
astropy:mainfrom
keflavich:verify_https_FIRSTandMAGPIS

Conversation

@keflavich

Copy link
Copy Markdown
Contributor

Addresses #2345. verify=False was a workaround for the time when this site didn't have valid certificates.

valid certificates; they didn't when we put in the workaroud)
@codecov

codecov Bot commented Mar 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2350 (afe9bd3) into main (60db44d) will increase coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2350      +/-   ##
==========================================
+ Coverage   62.97%   63.41%   +0.43%     
==========================================
  Files         131      131              
  Lines       17073    17043      -30     
==========================================
+ Hits        10752    10808      +56     
+ Misses       6321     6235      -86     
Impacted Files Coverage Δ
astroquery/image_cutouts/first/core.py 92.68% <ø> (ø)
astroquery/magpis/core.py 93.61% <ø> (ø)
astroquery/alma/utils.py 18.12% <0.00%> (-11.29%) ⬇️
astroquery/utils/commons.py 78.39% <0.00%> (+0.10%) ⬆️
astroquery/alma/core.py 42.80% <0.00%> (+1.63%) ⬆️
astroquery/heasarc/core.py 73.79% <0.00%> (+54.64%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bsipocz

bsipocz commented Mar 29, 2022

Copy link
Copy Markdown
Member

This is great, thanks!

@bsipocz bsipocz merged commit 4c33104 into astropy:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants