Skip to content

MNT: Fix incomplete URLs in regrex#2394

Merged
bsipocz merged 1 commit into
astropy:mainfrom
bsipocz:links_fix_regrex
May 5, 2022
Merged

MNT: Fix incomplete URLs in regrex#2394
bsipocz merged 1 commit into
astropy:mainfrom
bsipocz:links_fix_regrex

Conversation

@bsipocz

@bsipocz bsipocz commented May 5, 2022

Copy link
Copy Markdown
Member

These were picked up by codeQL as potential risks.

@codecov

codecov Bot commented May 5, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2394 (6358629) into main (96f63eb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2394   +/-   ##
=======================================
  Coverage   62.87%   62.87%           
=======================================
  Files         133      133           
  Lines       17246    17246           
=======================================
  Hits        10844    10844           
  Misses       6402     6402           
Impacted Files Coverage Δ
astroquery/eso/core.py 29.09% <ø> (ø)
astroquery/fermi/core.py 89.23% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bsipocz

bsipocz commented May 5, 2022

Copy link
Copy Markdown
Member Author

I'm not sure why these started to cause CI failures recently, nevertheless this fix seems to be enough to get rid of that failure, so I go ahead and merge it now.

@bsipocz bsipocz merged commit f20c85b into astropy:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant