Fix for CDMS issue 2409: mis-parsed GUP#2411
Conversation
| CDMS.query_lines(200*u.GHz, 230.755608*u.GHz, molecule='HC7N',parse_name_locally=True) | ||
| """ | ||
|
|
||
| tbl = CDMS.query_lines(200*u.GHz, 230.755608*u.GHz, molecule='HC7N', parse_name_locally=True) |
There was a problem hiding this comment.
I wonder whether this should be a remote test instead? (or a remote as well?)
|
Ohh, test failure is relevant, too. |
|
Hello @keflavich! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-05-23 00:56:52 UTC |
Codecov Report
@@ Coverage Diff @@
## main #2411 +/- ##
=======================================
Coverage 62.96% 62.97%
=======================================
Files 133 133
Lines 17287 17290 +3
=======================================
+ Hits 10885 10888 +3
Misses 6402 6402
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bsipocz
left a comment
There was a problem hiding this comment.
I plan to just add this PR number to the existing changelog for the previous issue, but feel free to add a separate entry if you feel it's useful to distinguish them.
|
Thanks @keflavich! |
This covers a case that is not described in the documentation: GUP starts at a different character than I had assumed, and it uses letters for numerical values >10
https://cdms.astro.uni-koeln.de/classic/predictions/description.html
fixes #2409