Esa hst fixing tests#2461
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2461 +/- ##
=======================================
Coverage 62.92% 62.92%
=======================================
Files 133 133
Lines 17300 17300
=======================================
Hits 10886 10886
Misses 6414 6414 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bsipocz
left a comment
There was a problem hiding this comment.
Thank you!
I'm waiting for the remote tests to pass, and have these two minor comments which I'll address before merging.
| esa_hubble = ESAHubble() | ||
| result = esa_hubble.get_member_observations('hst_16316_71_acs_sbc_f150lp_jec071i9') | ||
| assert result == ['hst_16316_71_acs_sbc_f150lp_jec071'] | ||
| assert result == [' hst_16316_71_acs_sbc_total_jec071', 'hst_16316_71_acs_sbc_f150lp_jec071'] |
There was a problem hiding this comment.
indeed the space is necessary, however, that is a big weird behaviour, is it maybe a bug @javier-ballester
| hst | ||
| ^^^ | ||
|
|
||
| - Fixed failing hst remote tests [#2461] |
There was a problem hiding this comment.
no changelog is needed for non user-facing changes or documentation only PRs
|
Actually, this doesn't address #2107, the temp files are still dumped into the main directory after running pytest, so I keep that issue open, but go ahead and merge the PR as it indeed addresses the failing tests. |
fa74b15 to
c5a9543
Compare
Dear Astroquery team,
These changes have been made to fix issues 2107 and 2359.
Kind regards,
@esdc-esac-esa-int