Change RMF matrices version#2472
Merged
bsipocz merged 1 commit intoJul 22, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2472 +/- ##
=======================================
Coverage 62.92% 62.92%
=======================================
Files 133 133
Lines 17302 17302
=======================================
Hits 10888 10888
Misses 6414 6414
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bsipocz
approved these changes
Jul 22, 2022
Member
|
Thanks @javier-ballester! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Astroquery,
The RMF to be used for the spectral analysis should be generated with the same PPS version as the spectrum, background and ARF. The PPS version can be found in SASVERS keyword in the SPECTRUM file, characters [-6:-3]. Once the sas version is determined, the code should look for the proper version of RMF in the FTP tree. However, for the current PPS versions available in the archive, i.e v18.0,v19.0 and v20.0, all RMF matrices are equal among the versions and for all instruments, so it is possible to download the last one, v20.0, available in the root FTP stored in 'rmf_ftp'. In the future, the FTP tree and/or PPS keywords will be modified to make easier to download the appropriate RMF file for each spectrum.
At the moment the version for the RMF matrices is v20.0 so the link to the proper file does not work. Therefore we need this quick patch to get the links to work again.
Kind regards,
Xmm_newton team