converting input lists to np arrays#2504
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2504 +/- ##
=======================================
Coverage 62.99% 62.99%
=======================================
Files 133 133
Lines 17291 17293 +2
=======================================
+ Hits 10892 10894 +2
Misses 6399 6399
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bsipocz
reviewed
Aug 26, 2022
bsipocz
left a comment
Member
There was a problem hiding this comment.
Please add a test and a changelog
|
Hello @jaymedina! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-08-29 15:14:42 UTC |
4f70da6 to
dcc62fd
Compare
jaymedina
added a commit
to jaymedina/jwebbinar_prep
that referenced
this pull request
Sep 9, 2022
Updating `astroquery` dependency on `requirements.txt`. During our testing of the notebooks we found and fixed an `astroquery` bug (see astropy/astroquery#2504) which was merged, but will not be reflected in the latest `astroquery` release 0.4.6. This change will point users to the latest development version of `astroquery` which contains the recent bug fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
astroquery.mast.Observations.get_product_listwas mishandling lists because the assumed input was a numPy array. This led to incorrect requests being made to our API. This PR adds a conditional to catch for incoming lists to convert them into numPy arrays before handling.Before:
After: