Skip to content

Update VSA url#3033

Merged
bsipocz merged 2 commits into
astropy:mainfrom
robertdstein:vsaurl
Jun 12, 2024
Merged

Update VSA url#3033
bsipocz merged 2 commits into
astropy:mainfrom
robertdstein:vsaurl

Conversation

@robertdstein

Copy link
Copy Markdown

The VSA url seems to be outdated (horus.roe.ac.uk rather than vsa.roe.ac.uk). I'm not sure when exactly the URL changed, but navigating in a browser to http://horus.roe.ac.uk will redirect to the new vsa.roe.ac.uk page. At a guess, I'd say this URL change is also why the VSA tests stopped working (#2828).

Anyway, this PR just updates the URL to the new one. Having tested locally, the queries etc now work as expected with the new URL.

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This indeed fixes the current test failures, so I'll add a short changelog entry and merge it in.

(I'm not sure #2828 was related, that one eventually self resolved)

@bsipocz bsipocz marked this pull request as ready for review June 12, 2024 22:27
@bsipocz bsipocz added this to the v0.4.8 milestone Jun 12, 2024
@bsipocz bsipocz merged commit 4a347cd into astropy:main Jun 12, 2024
@bsipocz

bsipocz commented Jun 12, 2024

Copy link
Copy Markdown
Member

Thanks @robertdstein!

@robertdstein robertdstein deleted the vsaurl branch June 27, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants