fix: turn detailed membership on by default#3195
Merged
bsipocz merged 2 commits intoFeb 3, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3195 +/- ##
=======================================
Coverage 68.34% 68.34%
=======================================
Files 231 231
Lines 19190 19190
=======================================
Hits 13116 13116
Misses 6074 6074 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Set to draft: waiting for a review from my colleagues. |
bsipocz
reviewed
Jan 30, 2025
f39a8f2 to
03a82ad
Compare
hiding the details should only be done with caution
03a82ad to
fd4f1a6
Compare
keflavich
approved these changes
Feb 3, 2025
keflavich
left a comment
Contributor
There was a problem hiding this comment.
Minor English comments. Looks great!
Co-authored-by: Adam Ginsburg <keflavich@gmail.com>
Member
Author
|
Thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got feedback that having
detailed_membershipturned off by default leads to big interpretation errors.This PR changes the default behavior, but also adds a more detailed documentation on the meaning of
membership_certaintyin the hope that this will help the interpretation of the results of the methodquery_hierarchy.