MAINT: remove the usage of TestRunner therefore remove astroquery.test()#3215
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3215 +/- ##
==========================================
- Coverage 68.31% 68.26% -0.06%
==========================================
Files 231 230 -1
Lines 19199 19164 -35
==========================================
- Hits 13116 13082 -34
+ Misses 6083 6082 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| # add '_testrun' to the version name so that the user-agent indicates that | ||
| # it's being run in a test | ||
| from . import version | ||
| version.version += '_testrun' |
Member
There was a problem hiding this comment.
Actually, I think this was really useful for the usage statistics. Could it be kept/reproduced?
Member
Author
There was a problem hiding this comment.
This should all be the case, this PR just removed the duplicated conftest file, but the remaining one on the top level should still contain all the useful bits and pieces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't advertise it in the docs (e.g. https://astroquery.readthedocs.io/en/latest/testing.html), the API docs was not exposed either, so I do this without a deprecation but if there is a veto I'm happy to go via deprecation instead.
CC-ing some of the most frequent contributors to give their thumbs up
cc @keflavich @ManonMarchand @andamian @jespinosaar @snbianco