EUCLID: the parameter output_file is not properly used in the method get_spectrum #3253
Merged
bsipocz merged 5 commits intoMar 16, 2025
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3253 +/- ##
==========================================
- Coverage 69.10% 69.09% -0.02%
==========================================
Files 232 232
Lines 19634 19637 +3
==========================================
Hits 13568 13568
- Misses 6066 6069 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keflavich
reviewed
Mar 14, 2025
Member
|
I rebase this to remove the datalink-related back-and-forth commits that are included in the other PR. |
added 5 commits
March 15, 2025 18:59
314b7ea to
7494746
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Astroquery team,
we want to fix the method get_spectrum in the Euclid module, so that the parameter output_file is properly used. We check that the output directory, defined by the the parameter output_file, is empty before it is used. Otherwise, the number of the returned files by this method could be incorrect. Also we have added the missing .zip extension when is necessary.
cc @esdc-esac-esa-int
jira: EUCLIDPCR-1914