fix-3269: add support for rows in heasarc.download_data#3270
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3270 +/- ##
=======================================
Coverage 69.08% 69.09%
=======================================
Files 232 232
Lines 19673 19677 +4
=======================================
+ Hits 13591 13595 +4
Misses 6082 6082 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @zoghbi-a , the same can done for |
bsipocz
reviewed
Mar 24, 2025
bsipocz
left a comment
Member
There was a problem hiding this comment.
One minor cleanup comment that I would apply before merging.
Thanks!
bsipocz
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for passing
astropy.table.Rowtoheasarc.download_data. Fixes #3269 and fixes #3271