GAIA: update the authentication implementation to read the cookies sent by the new ESAC tap mechanism#3289
Merged
bsipocz merged 7 commits intoApr 14, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3289 +/- ##
==========================================
+ Coverage 69.37% 69.48% +0.11%
==========================================
Files 232 232
Lines 19689 19703 +14
==========================================
+ Hits 13659 13691 +32
+ Misses 6030 6012 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 6 commits
April 11, 2025 21:46
bsipocz
approved these changes
Apr 14, 2025
bsipocz
left a comment
Member
There was a problem hiding this comment.
This all looks good. Given that it's very much an internal detail rather than user facing, I don't think it needs a changelog, but it's also OK to leave one in.
Unless you say otherwise I'll remove the one at release time.
Comment on lines
-882
to
+883
| def __find_column(columnName, columns): | ||
| for c in (columns): | ||
| if c.name == columnName: | ||
| def __find_column(column_name, columns): | ||
| for c in columns: | ||
| if c.name == column_name: |
Member
There was a problem hiding this comment.
Thanks for doing all this cleanup, too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear astroquery team,
the ESAC team has released a new tap library (v10.1.0) that implements a new authentication mechanism: the cookies are associated to the key SESSION, while in previous versions of the library the JSESSIONID is used instead.
We have updated the implementation in astroquery/utils/tap/core.py, so the new key SESSION is read if it is present in the header. Note that this implementation is backward compatible.
cc @esdc-esac-esa-int
jira: GAIAPCR-1341