Accept lists for MastMissions query criteria#3319
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3319 +/- ##
=======================================
Coverage 69.88% 69.89%
=======================================
Files 232 232
Lines 19761 19767 +6
=======================================
+ Hits 13810 13816 +6
Misses 5951 5951 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, in order to filter by multiple values for a criterion in
MastMissions, users would have to pass in a comma-delimited string. This PR adds support for a list of values. It also allows users to pass in a single string for thesort_bykeyword and a single boolean for thesort_desckeyword rather than a list.In addition, this PR does some additional error handling to be more helpful to users when they make invalid queries. If the request comes back with a HTTP 400 or 500 error (both indicative of bad input), an
InvalidQueryErroris raised that advises the user to check their query.