Skip to content

MAINT: bumping minimum required pytest version and fixes coverage job#3337

Merged
bsipocz merged 3 commits into
astropy:mainfrom
bsipocz:MAINT_bump_minpytest
Jun 4, 2025
Merged

MAINT: bumping minimum required pytest version and fixes coverage job#3337
bsipocz merged 3 commits into
astropy:mainfrom
bsipocz:MAINT_bump_minpytest

Conversation

@bsipocz

@bsipocz bsipocz commented Jun 4, 2025

Copy link
Copy Markdown
Member

This should fix the CI failure for the oldestdeps job (a newer version was picked up there, and there is really no point in forcing the plugins to have older versions for the sake of keeping the 6.0 in place.

I couldn't reproduce the devdeps failure locally, but will iterate on it in this PR.

@codecov

codecov Bot commented Jun 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.87%. Comparing base (fd08e21) to head (d7cdfd7).
⚠️ Report is 120 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3337   +/-   ##
=======================================
  Coverage   69.87%   69.87%           
=======================================
  Files         232      232           
  Lines       19770    19770           
=======================================
  Hits        13815    13815           
  Misses       5955     5955           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz force-pushed the MAINT_bump_minpytest branch from 5885080 to d7cdfd7 Compare June 4, 2025 19:08
@bsipocz

bsipocz commented Jun 4, 2025

Copy link
Copy Markdown
Member Author

A warning from pytest-cov now raised as an exception, while it was silently ignored when using pytest<8.4 (pytest-dev/pytest-cov#693 (comment)).

It's not clear which other plugin triggers it, I suspect it maybe related to getting the version info for pytest-astropy-header; but either case, it doesn't matter, we really just can ignore it.

@bsipocz bsipocz changed the title MAINT: bumping minimum required pytest version MAINT: bumping minimum required pytest version and fixes coverage job Jun 4, 2025
Comment on lines -277 to -278
# The ``W06: Invalid UCD 'meta.ref.url;meta.curation'`` warning is only raised with older astropy
with pytest.warns(W06) if ASTROPY_LT_5_3 else nullcontext():

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this disappeared with updating the minimum pytest version, but it's gone, and as it was a workaround anyway I don't investigate further.

@bsipocz bsipocz merged commit 5b4ffe6 into astropy:main Jun 4, 2025
17 of 18 checks passed
@bsipocz bsipocz deleted the MAINT_bump_minpytest branch June 4, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant