Skip to content

GAIA: new DR4 datalink retrieve type MEAN_SPECTRUM_RVS#3342

Merged
bsipocz merged 3 commits into
astropy:mainfrom
esdc-esac-esa-int:ESA_gaia_GAIASWRQ-45_new_datalink_retrieve_type_RVS_mean_DR4
Jun 10, 2025
Merged

GAIA: new DR4 datalink retrieve type MEAN_SPECTRUM_RVS#3342
bsipocz merged 3 commits into
astropy:mainfrom
esdc-esac-esa-int:ESA_gaia_GAIASWRQ-45_new_datalink_retrieve_type_RVS_mean_DR4

Conversation

@cosmoJFH

@cosmoJFH cosmoJFH commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Dear astroquery team,

we would like to rename the DR4 dataLink "RVS" retrieval_type to "MEAN_SPECTRUM_RVS" (compared to the Gaia DR3 value "RVS").

Please keep in mind that this does not break the code because the Gaia DR4 is not yet available to the public.

cc @esdc-esac-esa-int
jira:GAIASWRQ-45

@cosmoJFH cosmoJFH changed the title GAIA: ew DR4 datalink retrieve type MEAN_SPECTRUM_RVS GAIA: new DR4 datalink retrieve type MEAN_SPECTRUM_RVS Jun 10, 2025
@codecov

codecov Bot commented Jun 10, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.08%. Comparing base (d140a90) to head (1becbba).
⚠️ Report is 96 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3342   +/-   ##
=======================================
  Coverage   70.07%   70.08%           
=======================================
  Files         232      232           
  Lines       19884    19890    +6     
=======================================
+ Hits        13934    13940    +6     
  Misses       5950     5950           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cosmoJFH cosmoJFH added the gaia label Jun 10, 2025
@bsipocz bsipocz added this to the v0.4.11 milestone Jun 10, 2025

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to double check, we did the revert for this before as the server side wasn't ready, and now do the changes again, or there is something I missed?

#3238

@cosmoJFH

cosmoJFH commented Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

In #3238 we committed the changes by mistake. Now we have also updated the gaia archive to handle this new retrieve type.

@bsipocz bsipocz merged commit 0a65078 into astropy:main Jun 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants