Skip to content

BUGFIX: http->https in skyview#3346

Merged
bsipocz merged 3 commits into
astropy:mainfrom
keflavich:issue3345skyview
Jun 12, 2025
Merged

BUGFIX: http->https in skyview#3346
bsipocz merged 3 commits into
astropy:mainfrom
keflavich:issue3345skyview

Conversation

@keflavich

@keflavich keflavich commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Resolves Issue #3345, i.e., the upstream bug in which queries hang indefinitely.

If you've arrived here from another issue, please install the latest astroquery version. The skyview problems reported in June 2025 have been solved.

  • TODO: add test (currently, I have a failing test)

@keflavich keflavich marked this pull request as draft June 12, 2025 17:47
@codecov

codecov Bot commented Jun 12, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (1becbba) to head (0ecf641).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3346   +/-   ##
=======================================
  Coverage   70.08%   70.08%           
=======================================
  Files         232      232           
  Lines       19890    19890           
=======================================
  Hits        13940    13940           
  Misses       5950     5950           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@keflavich keflavich marked this pull request as ready for review June 12, 2025 17:58
@bsipocz

bsipocz commented Jun 12, 2025

Copy link
Copy Markdown
Member

Hahh, I guess I better push small fixes more frequently, I have that doctest fixed on a local branch since April 😅

@bsipocz bsipocz merged commit a4770a9 into astropy:main Jun 12, 2025
1 check passed
@bsipocz

bsipocz commented Jun 12, 2025

Copy link
Copy Markdown
Member

(haven't notice it in time, but please use the magic words right before the PR number next time

@keflavich

Copy link
Copy Markdown
Contributor Author

Ahhh crap, I can't say "resolves issue X", I have to say "resolves X"!?!? argh, I'm a terrible magician

@carlos-lco

Copy link
Copy Markdown

Hi there. Thanks a lot for tip Adam.
In fact, I piped to the new version using "--pre", changing from 0.4.10 to 0.4.11,
and now the SkyView works.
However, Astroplan uses the function SkyView with an argument (grid)
that seems deprecated in the new version. So astroplan users probably will need
to request an update on the "finder" function as well.

@keflavich

Copy link
Copy Markdown
Contributor Author

@carlos-lco thanks for the note; that seems like an issue that needs to be posted on astroplan - is there one open?

@carlos-lco

Copy link
Copy Markdown

Yes, SkyView # 588. I just noticed it. And you wrote on it! I should investigate more before posting. Sorry.

@keflavich

keflavich commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

No worries. That was a long time ago (in my head anyway), I forgot about it. Would you be interested in trying to fix that issue? I'm sure a pull request would be welcome.

@bsipocz

bsipocz commented Jun 19, 2025

Copy link
Copy Markdown
Member

This latest change in skyview is really just about the server side turning off the http access due to their DoS attacks. , the underlying API has not changed. (That being said, it would be great if downstream would fix these sooner rather than later).

@carlos-lco

Copy link
Copy Markdown

No worries. That was a long time ago (in my head anyway), I forgot about it. Would you be interested in trying to fix that issue? I'm sure a pull request would be welcome.

I just did. Crossed fingers. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SkyView.get_images() fails with Connection aborted. OSError(57, 'Socket is not connected') on macOS

3 participants