ESA Plato Astroquery module by jespinosaar · Pull Request #3573 · astropy/astroquery

jespinosaar · 2026-03-31T11:49:44Z

Dear Astroquery Team,

Many thanks for merging PR #3511. With this, we can now proceed with the new module we already discussed.

We have been preparing a module for the PLATO Archive, to be available for the Guest Observer call for proposals, providing relevant information that may be helpful for astronomers. For this, if possible, we would like to iterate with you and merge this branch as soon as possible, so we have a pre-released version right after this is merged. You can find more information here:

https://www.cosmos.esa.int/web/plato/getting-ready

With this, we have prepared a module based on the EsaTap class we have already discussed, together with specific methods to retrieve data from these catalogues. As you will see, there is also a method to plot data, but we are detecting there if matplotlib is imported and, if not, it raises an exception. This method is also relevant, as it mimics the behavior of an application that is currently used, providing the same features in python script to our users.

With respect to tests, you will see that we have the offline tests and the documentation tests are set to be skipped. This is due to the URL of the TAP, currently not available for the public audience, but it will be opened next week. Right after the Archive is public, we will create another pull request to remove the SKIP clauses and add the remote tests, that we already have.

Many thanks for your support! Please let us know any comment you have.

Kind regards,
@jespinosaar

cc @esdc-esac-esa-int

codecov · 2026-03-31T11:53:58Z

Codecov Report

❌ Patch coverage is 88.60759% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.20%. Comparing base (dbf41fd) to head (237a3e0).
⚠️ Report is 201 commits behind head on main.

Files with missing lines	Patch %	Lines
astroquery/esa/plato/core.py	85.93%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3573      +/-   ##
==========================================
+ Coverage   73.10%   73.20%   +0.10%     
==========================================
  Files         224      226       +2     
  Lines       20839    20966     +127     
==========================================
+ Hits        15234    15349     +115     
- Misses       5605     5617      +12

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jespinosaar · 2026-03-31T15:31:34Z

After some iterations, I managed to pass all the checks. @bsipocz , please let me know if you have any comment

jespinosaar · 2026-04-06T08:19:53Z

Just added the latest changes in the manual.

bsipocz

Overall this looks good for the archive launch. There are a few minor typos, and extra files, but none are blockers.

I would also think that the search_pic_* methods could be merged into one and have an extra kwarg that would select between target and contaminant to keep the API a bit simpler of practically duplicated functionalities. But this is not a strong preference.

bsipocz · 2026-04-06T20:39:29Z

Remove this file as it is not required/used with the refactored infrastructure.
(All the tests/data files are included by default in the new)

I just removed this file

bsipocz · 2026-04-06T20:40:26Z

normally I would say don't add this file until it's functional, but as it's already been included, we could keep it.

I initially added this as a mistake, but I thought I had remove it. Now it is not included, I just removed it.

bsipocz · 2026-04-06T20:41:15Z

+    def search_catalogue(self, table_name, *, target_name=None, coordinates=None, radius=1*u.arcmin, columns=None,
+                         get_metadata=False, output_file=None, **filters):
+        """
+        Execute a search in one of the catalogues and associated tbles available in PLATO TAP.


Suggested change

Execute a search in one of the catalogues and associated tbles available in PLATO TAP.

Execute a search in one of the catalogues and associated tables available in PLATO TAP.

Thanks for spotting this, I already fixed this

bsipocz · 2026-04-06T20:45:07Z

+            raise TypeError("Please use only target or coordinates as "
+                            "parameter.")


Suggested change

raise TypeError("Please use only target or coordinates as "

"parameter.")

raise TypeError("Please use only 'target_name' or 'coordinates' as "

"parameter, not both.")

Just rewrited this

bsipocz · 2026-04-06T20:46:16Z

+                                custom_filters=cone_search_filter, get_metadata=get_metadata, async_job=True,
+                                output_file=output_file, **filters)
+
+    def search_pic_target_go(self, *, target_name=None, coordinates=None, radius=1*u.arcmin, columns=None,


what does go mean in the name?

GO means Guest Observer, as these methods are developed for the Guest Observer Call for Proposals

bsipocz · 2026-04-06T20:49:35Z

+----------------------------
+
+The Query TAP functionality facilitates the execution of custom Table Access Protocol (TAP)
+queries within the PLATO ArXiv. Results can be exported to a specified


Will you spell the plato archive as Arxiv?

Yes, the acronym chosen for PLATO Archive is PAX (Plato ArXiv). I know this is different from others, but this is how it was decided.

bsipocz · 2026-04-06T20:51:01Z

+    def search_pic_target_go(self, *, target_name=None, coordinates=None, radius=1*u.arcmin, columns=None,
+                             get_metadata=False, output_file=None, **filters):
+        """
+        Execute a search in PIC Target Catalogue.


Long term this could use another sentence or two of description.

I added some words with more info.

jespinosaar · 2026-04-06T21:35:55Z

I added your comments, but it seems that when removing the setup_package file this is not working. Let me check

bsipocz · 2026-04-06T21:37:08Z

@jespinosaar - to me it looks like the issue from the changing of the error message.

I'm happy to fix all of these up and merge it in the next hour or so, no need to spend your time with it during Easter.

jespinosaar · 2026-04-06T21:40:16Z

@jespinosaar - to me it looks like the issue from the changing of the error message.

I'm happy to fix all of these up and merge it in the next hour or so, no need to spend your time with it during Easter.

Yes, I realized about that after checking, just added a new commit to fix this.

jespinosaar · 2026-04-06T21:45:38Z

I agree, maybe it is a good idea to add an extra kwarg for the search_pic methods. But, for now, we were requested to include two separate methods. So, if it is ok with you, let's keep it like this for now.

On the other hand, it seems that now the pipeline will finish successfully.

bsipocz

OK, let's have this in for now and we can iterate as needed once the service is up and running.

bsipocz · 2026-04-06T21:58:44Z

+                                     coordinates=coordinates, radius=radius, columns=columns,
+                                     get_metadata=get_metadata, output_file=output_file, **filters)
+
+    def plot_plato_results(self, x, y, x_label, y_label, plot_title, *, z=None, z_label=None, error_x=None,


I'm not certain that this plotting belongs to astroquery, but we can clean this up later.

jespinosaar · 2026-04-06T22:04:32Z

Many many thanks!! And sure, let's iterate on this later. Just let me know when the pre-release version is available, and so the new documentation

bsipocz · 2026-04-07T02:47:19Z

Dev release is on pypi, pip install --pre -U astroquery should be able to pick it up.

jespinosaar · 2026-04-07T08:25:23Z

Yes, everything is working as expected, many thanks!!!

PLATOWRQ-402: ESA Plato Astroquery module

4bd69eb

jespinosaar added 8 commits March 31, 2026 13:58

PLATOWRQ-402: remote tests removed

1b7f46e

PLATOWRQ-402: code style fixes

c2d2feb

PLATOWRQ-402: added changelog

61cd006

PLATOWRQ-402: fixes in style and docs

14d6eb6

PLATOWRQ-402: fixes style -length of line

43b0707

PLATOWRQ-402: docs fixed

8ffe904

PLATOWRQ-402: docs with correct format

bbbdeb6

PLATOWRQ-402: docs with correct blank lines

5aca943

jespinosaar added 2 commits March 31, 2026 17:42

PLATOWRQ-402: disclaimer for opening on April 7th

875f7cc

PLATOWRQ-402: final docs formatting

ba9f66e

bsipocz added New Service esa.plato labels Mar 31, 2026

bsipocz added this to the 0.4.12 milestone Mar 31, 2026

PLATOWRQ-402: documentation updates

7fccb7c

bsipocz approved these changes Apr 6, 2026

View reviewed changes

PLATOWRQ-402: feedback from astroquery team

15f27e3

PLATOWRQ-402: tests fixed

237a3e0

bsipocz approved these changes Apr 6, 2026

View reviewed changes

bsipocz merged commit c09c9eb into astropy:main Apr 6, 2026
11 checks passed

bsipocz reviewed Apr 6, 2026

View reviewed changes

bsipocz mentioned this pull request Apr 8, 2026

PLATOWRQ-402: remote and doc tests added #3577

Merged

	Execute a search in one of the catalogues and associated tbles available in PLATO TAP.
	Execute a search in one of the catalogues and associated tables available in PLATO TAP.

		raise TypeError("Please use only target or coordinates as "
		"parameter.")

Uh oh!

Uh oh!

Conversation

jespinosaar commented Mar 31, 2026

Uh oh!

codecov Bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jespinosaar commented Mar 31, 2026

Uh oh!

jespinosaar commented Apr 6, 2026

Uh oh!

bsipocz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jespinosaar commented Apr 6, 2026

Uh oh!

bsipocz commented Apr 6, 2026

Uh oh!

jespinosaar commented Apr 6, 2026

Uh oh!

jespinosaar commented Apr 6, 2026

Uh oh!

bsipocz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jespinosaar commented Apr 6, 2026

Uh oh!

bsipocz commented Apr 7, 2026

Uh oh!

jespinosaar commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Mar 31, 2026 •

edited

Loading