Fix for tox -e build_docs#3584
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3584 +/- ##
=======================================
Coverage 73.22% 73.22%
=======================================
Files 226 226
Lines 21000 21000
=======================================
Hits 15378 15378
Misses 5622 5622 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is weird, I don't have any issues with it neither on my default 3.12 nor with python 3.14. Can you show some tracebacks (either here or on slack). |
There was a problem hiding this comment.
We had some dive in here and concluded not to have this PR.
-
I couldn't reproduce and tried with 3.11, 3.12, and 3.14; with brand new and older setuptools versions, but I wasn't systematic enough, really just let tox run
-
Sam only experienced it on 3.11 but it works in here newer versions. [edit: deleting the
.toxdirectory seems to do the trick] -
there is the note on packaging documentation which I think is what we run into (https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license-and-license-files):
Note
If you get a build error that license should be a dict/table, your build backend doesn’t yet support the new format. See the above section for more context. The now deprecated format is described in PEP 621.
|
OK, closing it, but thanks for the rabbit hole dive, we clearly don't cover all the build cases and versions, but based on the python packaging documentation, what we have in the toml file should be correct. I have patched up some of the inconsistencies we run into, but haven't dived into adding further recommendations into the narrative docs. |
The
tox -e build_docscommand has been failing for me, and I think it's because of recent updates tosetuptools. These changes topyproject.tomlfixed the build for me.