Fix Device ENDRESTORE to not delete existing objects until after the first record is decoded - #1352
Merged
skarg merged 1 commit intoMay 18, 2026
Conversation
…t record is decoded
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Device_End_Restore so existing objects aren't deleted until the backup file's first record is successfully decoded, preventing data loss when the backup is empty or corrupt.
Changes:
- Move the Device_Delete_Objects() call from before the decode loop to inside the loop, gated by offset == 0 and a successful decode.
- Apply the same change in both device.c and bacnet_device.c implementations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/bacnet/basic/server/bacnet_device.c | Defer Device_Delete_Objects() until after first record decode succeeds. |
| src/bacnet/basic/object/device.c | Same deferred-delete fix in the alternate Device implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skarg
deleted the
bugfix/reinitialize-device-ENDRESTORE-empty-restore-file
branch
May 18, 2026 19:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.